mm/pagebox: add dynamically-sized slice support #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is merged we can make the raw page allocation functions in |
At the moment, we initialize a global variable with a structure (`ValidBitmap`) that holds a raw pointer to a bitmap. To signal that the bitmap has not been initialized, we store a NULL pointer and check on every access. Instead of doing this, simply store an `Option<ValidBitmap>` in the global variable. If the bitmap has not been initialized, the `Option` will be `None`, which we are forced to check, avoiding potential NULL pointer dereferences and simplyfing some of the methods of `ValidBitmap`. Signed-off-by: Carlos López <carlos.lopezr4096@gmail.com>
Add support for allocating dynamically-sized slices of values using the page allocator. This essentially works like a regular Vec, except the slice does not support resizing once created. While we are at it, add a corresponding test. Signed-off-by: Carlos López <carlos.lopezr4096@gmail.com>
|
Applied Tom's suggestions and rebased on main |
Freax13
reviewed
Aug 16, 2024
Now that PageBox supports dinamically sized slices, use the abstraction to allocate the bitmap. Signed-off-by: Carlos López <carlos.lopezr4096@gmail.com>
Freax13
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for allocating dynamically-sized slices of values using the page allocator. This essentially works like a regular Vec, except the slice does not support resizing once created.
This is useful for the use case we have in the valid bitmap. Thus, replace the low-level page allocation calls in that code with
PageBoxuses.