Other plugin's highlights are broken by using hi clear

[Matts966]

Environment:

• OS: OSX
• Vim (:version)

NVIM v0.5.0-dev+nightly
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/clang -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNDEBUG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wv
la -fstack-protector-strong -fno-common -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/tmp/neovim-20210126-6283-12z99b1/bu
ild/config -I/tmp/neovim-20210126-6283-12z99b1/src -I/usr/local/include -I/tmp/neovim-20210126-6283-12z99b1/deps-build/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include -I/usr/local/opt/gettex
t/include -I/tmp/neovim-20210126-6283-12z99b1/build/src/nvim/auto -I/tmp/neovim-20210126-6283-12z99b1/build/include
Compiled by masahiromatsui@MBP

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/HEAD-69103ff/share/nvim"

Run :checkhealth for more info

• Terminal: alacritty

If you have a trouble with coloration and are using Vim/Neovim with terminal:

• Does your Vim support full colors? (:set termguicolors)
• Does your terminal support full colors? (e.g. Terminal.app doesn't support it)

---

Thank you for your great colorscheme! I enjoy iceberg for alacritty, vim, fzf, bat... etc. I would like to use iceberg with hop.nvim, but this issue break the highlights of it.

The 2 parts of the iceberg use hi clear

iceberg.vim/src/template.vim

Line 16 in 4bc68b2

hi clear

iceberg.vim/colors/iceberg.vim

Line 16 in 4bc68b2

hi clear

This clears all the user provided highlights, and changes colors like below.

before

after

Could you please remove hi clear lines?

Thank you.

[cocopon]

Thank you for using Iceberg!

hi clear is the standard way to initialize vim color schemes. Vim has an official color scheme linter and you can see that it checks an existence of this command:
https://github.com/vim/vim/blob/6914e87d3c0387fdcbb117a39e1f6d1fac0ee2e3/runtime/colors/tools/check_colors.vim#L146

I think it may be an issue of hop.nvim. For example, vim-easymotion defines its highlightings after appling a color scheme by autocmd ColorScheme * and it works well:
https://github.com/easymotion/vim-easymotion/blob/d75d9591e415652b25d9e0a3669355550325263d/autoload/EasyMotion/highlight.vim#L141

[cocopon]

Related: hadronized/hop.nvim#35

[Matts966]

Thank you for your kind explanation!
I would like to close this for hadronized/hop.nvim#35 tracks this problem.