fixed taobao-minigame use bitmapfont sometimes error #17023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bofeng-song
reviewed
May 23, 2024
| @@ -126,6 +126,8 @@ export default class Assembler2D extends Assembler { | |||
| indiceOffset = offsetInfo.indiceOffset, | |||
| vertexId = offsetInfo.vertexOffset; | |||
| for (let i = 0, l = iData.length; i < l; i++) { | |||
| //Because taobao-minigame does not allow out-of-bounds access to Uint16Array, otherwise it will report an error and cause the game to be unresponsive | |||
| if (cc.sys.platform === cc.sys.TAOBAO_MINIGAME && indiceOffset + 1 >= ibuf.length) break; | |||
There was a problem hiding this comment.
The last member can not be set normally.
bofeng-song
approved these changes
May 23, 2024
minggo
reviewed
May 23, 2024
| @@ -126,6 +126,8 @@ export default class Assembler2D extends Assembler { | |||
| indiceOffset = offsetInfo.indiceOffset, | |||
| vertexId = offsetInfo.vertexOffset; | |||
| for (let i = 0, l = iData.length; i < l; i++) { | |||
| //Because taobao-minigame does not allow out-of-bounds access to Uint16Array, otherwise it will report an error and cause the game to be unresponsive | |||
| if (cc.sys.platform === cc.sys.TAOBAO_MINIGAME && indiceOffset >= ibuf.length) break; | |||
There was a problem hiding this comment.
- why do it in for loop, can determine how much data to copy before for loop
- this PR means that on tabao platform, some data will not be copied into ibuf, can it work correctly on tabao platform?
There was a problem hiding this comment.
Yes, after project testing, this PR will not cause any abnormalities in the game, and it has solved the problem of the game not responding. I will try to handle this issue in a more performant way.
|
When increasing the value of indiceOffset, it should not exceed the array length of buffer._iData.
|
minggo
reviewed
May 28, 2024
| @@ -125,7 +125,7 @@ export default class Assembler2D extends Assembler { | |||
| let ibuf = buffer._iData, | |||
| indiceOffset = offsetInfo.indiceOffset, | |||
| vertexId = offsetInfo.vertexOffset; | |||
| for (let i = 0, l = iData.length; i < l; i++) { | |||
| for (let i = 0, l = this.indicesCount; i < l; i++) { | |||
| ibuf[indiceOffset++] = vertexId + iData[i]; | |||
There was a problem hiding this comment.
It may exceed iData too. So i think should use the min value of them, for example
const indicesToFill = min(this.indicesCount, iData.length);
minggo
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #17022