update alignWithScree in Canvas for fireball/issues/8281 #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandamicro
reviewed
Sep 3, 2018
cocos2d/core/components/CCCanvas.js
Outdated
| @@ -116,6 +118,7 @@ var Canvas = cc.Class({ | |||
| if (this._fitWidth !== value) { | |||
| this._fitWidth = value; | |||
| this.applySettings(); | |||
| this.onResized(); | |||
There was a problem hiding this comment.
顺便在 onResized 里面加上 size dirty check 吧，通过保存之前的 size 并且对比新的 size 来判断是否需要调用 alignWithScreen
pandamicro
approved these changes
Sep 4, 2018
knoxHuang
added a commit
to knoxHuang/engine-2
that referenced
this pull request
Dec 3, 2018
pandamicro
pushed a commit
that referenced
this pull request
Dec 3, 2018
xianyinchen
added a commit
to xianyinchen/engine
that referenced
this pull request
Dec 5, 2018
…into v2.1-release * 'v2.1-release' of https://github.com/cocos-creator/engine: (133 commits) refine image type check (cocos#3591) modify preloadScene API params (cocos#3583) V2.0 skeleton optimize (cocos#3537) update alignWithScree in Canvas for fireball/issues/8281 (cocos#3186) (cocos#3585) add platform differ on baiduGame, vivoGame and oppoGame (cocos#3582) add stopAnimation/startAnimation to game pasue/resume (cocos#3584) Fix failed to update particle system _renderSpriteFrame (cocos#3577) fixed bar-filled (cocos#3581) refine buffer view check (cocos#3578) fixed texture image check in wechat game platform (cocos#3576) upgrade del to 3.0 (cocos#3572) Fix rendering residue for transparent images on Chrome69. (cocos#3357) (cocos#3573) add system font to richtext (cocos#3570) fix outline enable and disable invaild / rm label updateRenderData CC_EDITOR (cocos#3567) optimize children (cocos#3552) fixed bar-filled (cocos#3566) RichText support node color settings (cocos#3560) improve rotateTo/rotateBy (cocos#3565) improve rotateTo/rotateBy (cocos#3563) fix outline enable and disable is invaild bug (cocos#3564) ...
minggo
pushed a commit
that referenced
this pull request
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/fireball#8281
Changelog: