-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccclass: show warning when using String/Number/Boolean as type #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jareguo
commented
Jun 25, 2019
attr: attr, | ||
getClassAttrs: getClassAttrs, | ||
getClassAttrsProto: getClassAttrsProto, | ||
setClassAttr: setClassAttr, | ||
DELIMETER: DELIMETER, | ||
getTypeChecker: getTypeChecker, | ||
ObjectType: ObjectType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
移除了 ObjectType,改为 getObjTypeChecker,和 getTypeChecker 行为保持一致
jareguo
changed the title
still work on ccclass: fix default value when using cc.String
ccclass: show warning when using String/Number/Boolean as type
Jun 25, 2019
jareguo
added a commit
to jareguo/engine
that referenced
this pull request
Oct 12, 2020
jareguo
added a commit
to jareguo/engine
that referenced
this pull request
Oct 12, 2020
pandamicro
pushed a commit
that referenced
this pull request
Oct 15, 2020
* remove asserts from addChild * expose js._registeredClassIds & js._registeredClassNames (sync #3174) To unload scripts dynamically. Also revert part of changes from https://github.com/cocos-creator/engine/pull/3204/files#diff-cabe5229c3c6e31339220008e54fe853L421 * remove unused code (sync #3174) * minor tweak (sync #3421) * should not invoke component if destroy() called before node activating (sync #3430) * node should removed and destroyed with scene (sync #3456 #3483) * fix WebGL detection on Android browsers (sync #3510) * remove redundant right shift for bitwise operation (sync #3754) * fix label blur when using dark font color (sync #3949) * refine tooltip of Block Input Event (sync #4053) * fix IE/Edge exception when output log/warn before engine initialization(sync #4447, #4500) * sync class, attribute (#4689, #4712, #4781, #4712) * fix loading unknown texture format (sync #4820) * prefer toLowerCase to toLocaleLowerCase + sync #5114 * optimize bezier calculation (sync #5155) * fix potential memory leak in scene-editor (sync #5643) * fix _posDirty error of Mask on native platform (sync #6168)
pandamicro
added a commit
that referenced
this pull request
Oct 22, 2020
* tweaks tooltip of isTrigger (#7485) * UI material stencil state change bug fix (#7497) * auto-shadow-info (#7404) * auto-shadow-info * add bais control * update control name * merge cc_shadowPCF(Vec2) && cc_shadowSize(Vec2) to cc_shadowInfo(Vec4) * fix terrain bound error, terrain support dynamic lighting (#7505) * fix terrain bound error, terrain support dynamic lighting * fix terrain fog Co-authored-by: Myway3D1 <404793124@qq.com> * 3d v1.2 terrain support dynamic lighting (#7510) * fix terrain bound error, terrain support dynamic lighting * fix terrain fog * standard surface add lighting map info * Revert pcf filter Co-authored-by: Myway3D1 <404793124@qq.com> * fix sphere.margeAABB bug (#7518) * fix sphere.margeAABB bug && Optimize automatic shadow calculation * Even if the obstruction is not in the field of view, the shadow is still visible * optimization,and avoid using sphere.radius < 0 * Avoid creating aabb repeatedly * update * adjust the Graphics structure to support continuous data filling (#7523) * adjust the Graphics structure to support continuous data filling (#7524) * Revert "adjust the Graphics structure to support continuous data filling (#7523)" This reverts commit b86f3cc. * adjust the Graphics structure to support continuous data filling (#7359) * add terrain shadow (#7500) * add terrain shadow * update * update * update * delete temp source code * Optimize the auto shadow * shadow 和 0 号对齐 * add reciveshadow control * cancel * fix shadow effect display error * update * use 1.0, doesnt use 1 in glsl * update effects * change bbMin && bbMax use Number.MAX_VALUE && Number.MIN_VALUE * update * update * correct ammo kinematic object (#7534) * remove asserts from addChild & sync 2D changes (#7479) * remove asserts from addChild * expose js._registeredClassIds & js._registeredClassNames (sync #3174) To unload scripts dynamically. Also revert part of changes from https://github.com/cocos-creator/engine/pull/3204/files#diff-cabe5229c3c6e31339220008e54fe853L421 * remove unused code (sync #3174) * minor tweak (sync #3421) * should not invoke component if destroy() called before node activating (sync #3430) * node should removed and destroyed with scene (sync #3456 #3483) * fix WebGL detection on Android browsers (sync #3510) * remove redundant right shift for bitwise operation (sync #3754) * fix label blur when using dark font color (sync #3949) * refine tooltip of Block Input Event (sync #4053) * fix IE/Edge exception when output log/warn before engine initialization(sync #4447, #4500) * sync class, attribute (#4689, #4712, #4781, #4712) * fix loading unknown texture format (sync #4820) * prefer toLowerCase to toLocaleLowerCase + sync #5114 * optimize bezier calculation (sync #5155) * fix potential memory leak in scene-editor (sync #5643) * fix _posDirty error of Mask on native platform (sync #6168) * fix terrain receive shadow (#7535) Co-authored-by: Myway3D1 <404793124@qq.com> * Fix terrain receive shadow and load layer texture (#7543) * fix terrain receive shadow * fix load layer texture Co-authored-by: Myway3D1 <404793124@qq.com> * ui batch marge for stencil (#7540) * tweaks (#7544) * fix sync instantiate-jit (#7550) * Refine type define * Fix TypedArray instantiation in Prefab (sync commit 0361c4e) * resign instantiate-jit #5114 * fix shadow.far not enough (#7548) * fix shadow.far not enough * Add restrictions * Remove duplicate code * Update distance.ts (#7558) 碰撞检测有问题 * update internal db prefab meta version (#7556) * Fix shadows merge conflicts Co-authored-by: jiaxin.lai <goodlaijiaxin@qq.com> Co-authored-by: ChiaNing <sun.cloud.mo@gmail.com> Co-authored-by: troublemaker52025 <troublemaker52025@outlook.com> Co-authored-by: Myway <MSoft1115@hotmail.com> Co-authored-by: Myway3D1 <404793124@qq.com> Co-authored-by: JoneLau <32630749+JoneLau@users.noreply.github.com> Co-authored-by: Jare Guo <jareguo@users.noreply.github.com> Co-authored-by: hujf <41710215+kissSimple@users.noreply.github.com> Co-authored-by: 黄森斌 <arsen2010@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://github.com/cocos-creator/3d-tasks/issues/766
Changes:
*