fixed calc material hash #5615
Merged
fixed calc material hash #5615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantyWang
reviewed
Oct 25, 2019
| hashData += prop._id + ';'; | ||
| } | ||
| else { | ||
| hashData += prop.toString() + ';'; |
There was a problem hiding this comment.
是之前hash的计算过程导致的实例化之后还识别为同个材质么？
caryliu1999
reviewed
Oct 25, 2019
| hashData += prop._id + ';'; | ||
| } | ||
| else { | ||
| hashData += prop.toString() + ';'; |
There was a problem hiding this comment.
如果是对象的话，所有对象进行 toString 的结果都是字符串 “object”，这个要注意一下，我看之前的 PARAM_MAT4 好像就是对象，还有其他情况是使用对象的吗？
There was a problem hiding this comment.
没有对象了，在解析的时候会全部转换为 ArrayBuffer
caryliu1999
approved these changes
Oct 25, 2019
2youyou2
commented
Oct 25, 2019
| } | ||
| else { | ||
| if (value && typeof value === 'object') { | ||
| cc.warn(`Set effect property ${this._name} warning : should transform object to ArrayBuffer`); |
There was a problem hiding this comment.
防止漏处理的对象，加个 warning
SantyWang
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/2d-tasks#2000
Changes: