add highp precision check #5675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandamicro
approved these changes
Nov 5, 2019
cocos2d/renderer/core/program-lib.js
Outdated
| highpSupported = highp && highp.precision !== 0; | ||
| } | ||
| if (!highpSupported) { | ||
| cc.warn('Program not support highp precision, will change to mediump.'); |
jareguo
reviewed
Nov 5, 2019
cocos2d/renderer/core/program-lib.js
Outdated
| @@ -63,6 +63,10 @@ function _unrollLoops(string) { | |||
| return string.replace(pattern, replace); | |||
| } | |||
|
|
|||
| function _replaceHighp(string) { | |||
| return string.replace(/\bhighp\b/, 'mediump'); | |||
|
这个是three的检测方式，看看有没有参考价值 |
加了 vertex precision 的检测，mediump 没加了，不支持游戏都玩不了了。。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/2d-tasks#844
Changes:
老设备上可能不支持 highp，这里判断如果设备不支持 highp 则替换 shader 中的 highp 为 mediump。