AnimationCurve #8409
Merged
AnimationCurve #8409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinktofit
force-pushed
the
AnimCurve
branch
4 times, most recently
from
72fda53
to
3967b18
Compare
shrinktofit
force-pushed
the
AnimCurve
branch
21 times, most recently
from
f559776
to
0070b31
Compare
|
This PR tends to be in version 3.2+. Please do not merge it into 3.1. @holycanvas |
|
The concepts and design document can be found at here. |
shrinktofit
force-pushed
the
AnimCurve
branch
2 times, most recently
from
75b803c
to
72d4ade
Compare
.interpMode -> .interpolationMode RealInterpMode -> RealInterpolationMode QuaternionInterpMode -> QuaternionInterpolationMode ExtrapMode -> ExtrapolationMode .preExtrap -> .preExtrapolation .postExtrap -> .postExtrapolation QuaternionCurve -> QuatCurve QuaternionKeyframeValue -> QuatKeyframeValue
pandamicro
suggested changes
Jul 22, 2021
| const ratios: number[] = []; | ||
| const eventGroups: IAnimationEventGroup[] = []; | ||
| const events = this.events.sort((a, b) => a.frame - b.frame); | ||
| for (const eventData of events) { |
| result[joint] = new BoneGlobalTransform(); | ||
| return result; | ||
| }, {} as Record<string, BoneGlobalTransform>); | ||
| for (const joint of Object.keys(skeletonFrames)) { |
| const parentJointName = joint.substring(0, parentJoint); | ||
| const parentJointFrame = skeletonFrames[parentJointName]; | ||
| if (!parentJointFrame) { | ||
| warn(`Seems like we have animation for ${joint} but are missing its parent joint ${parentJointName} in animation?`); |
| quatTrackEvalStatuses, | ||
| } = compressedDataEvalStatus; | ||
|
|
||
| for (const curves of this._curves) { |
| curves.evaluate(time, result); | ||
| } | ||
|
|
||
| for (const { target, curve } of quatTrackEvalStatuses) { |
| // trackConstructor: ColorTrack, | ||
| // properties: [['r', 0], ['g', 1], ['b', 2], ['a', 3]], | ||
| // } as ConvertMap<Color, ColorTrack>, | ||
| // ]; |
|
|
||
| set keys (value) { | ||
| this._keys = value; | ||
| } |
| return this._commonTargets; | ||
| } | ||
|
|
||
| set commonTargets (value) { |
| return track; | ||
| }); | ||
|
|
||
| for (const legacyCurve of legacyCurves) { |
pandamicro
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/3d-tasks#
Changelog:
*