Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove proj.android files for creator2.0 #1352

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

drelaptop
Copy link
Contributor

creator should do some corresponding changes

  1. remove ant modify script when build to avoid the errors below

ant-remote

  1. Don't copy build files for proj.android, like:

ant-remove-file

  1. others I don't know about ant and proj.android if existed

@jareguo please check this work

@jareguo
Copy link
Contributor

jareguo commented Jul 2, 2018

LGTM

@drelaptop
Copy link
Contributor Author

@jareguo thanks for review.

I can modify the cocos2d-x-lite and cocos-console for this work, but I know little for Creator Editor. So works mentioned above about the Editor need to be done by creator guys. I hope you can assign someone to do.

@jareguo
Copy link
Contributor

jareguo commented Jul 2, 2018

Sure, issues relative to the building can ask @wuzhiming for help.

@drelaptop
Copy link
Contributor Author

Thanks for share this. I think I should new a issue in fireball repo for the Editor works. Native part works was finished after the console sub-module updated.

@drelaptop drelaptop changed the title [Don't Merge] remove proj.android files for creator2.0 remove proj.android files for creator2.0 Jul 2, 2018
@drelaptop
Copy link
Contributor Author

@minggo please merge

this PR do those works:

  1. remove proj.android directory in link and default template
  2. sync sub-module cocos-console, including ant build script removed

@drelaptop
Copy link
Contributor Author

drelaptop commented Jul 2, 2018

Don't Merge !!! Until creator 2.0 beta was packaged finish.

@minggo minggo merged commit 6088b8b into cocos:next Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants