Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Socket.IO crash #2338

Merged
merged 1 commit into from Mar 30, 2020
Merged

fix Socket.IO crash #2338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cocos/network/SocketIO.cpp
View file
Open in desktop
Expand Up @@ -456,7 +456,7 @@ void SIOClientImpl::handshakeResponse(HttpClient* /*sender*/, HttpResponse *resp
sprintf(statusString, "HTTP Status Code: %ld, tag = %s", statusCode, response->getHttpRequest()->getTag());
CCLOGINFO("response code: %ld", statusCode);

if (!response->isSucceed())
if (!response->isSucceed() || statusCode >= 400)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statusCode 为错误码时, 连接不可继续

{
CCLOGERROR("SIOClientImpl::handshake() failed");
CCLOGERROR("error buffer: %s", response->getErrorBuffer());
Expand Down