Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsb] SocketIO client receives message twice #17490

Closed
dumganhar opened this issue Mar 13, 2017 · 1 comment
Closed

[jsb] SocketIO client receives message twice #17490

dumganhar opened this issue Mar 13, 2017 · 1 comment
Assignees

Comments

@dumganhar
Copy link

Reported at cocos/engine-native#563

  • cocos2d-x version: v3.14.1
  • devices test on: all
  • developing environments
    • NDK version:
    • Xcode version:
    • VS version:
    • browser type and version:

Steps to Reproduce:

@dumganhar dumganhar added this to the next milestone Mar 13, 2017
@dumganhar dumganhar self-assigned this Mar 13, 2017
@dumganhar dumganhar modified the milestones: 3.16, next Sep 20, 2017
@drelaptop drelaptop modified the milestones: 3.17, 3.18 May 21, 2018
@minggo minggo assigned PatriceJiang and unassigned dumganhar Jun 21, 2018
@PatriceJiang
Copy link
Contributor

PatriceJiang commented Jul 13, 2018

bug has been fixed before jul 10, 2017
cocos/scripting/js-bindings/manul/jsb_socketio.cpp

-    virtual void onMessage(SIOClient* client, const std::string& data)
+    virtual void onMessage(SIOClient* client, const std::string& data) override
     {
-        CCLOG("JSB SocketIO::SIODelegate->onMessage method called from native with data: %s", data.c_str());
-        this->fireEventToScript(client, "message", data);
     }
 

it is no longer exists in newer version. this issue should be closed, @minggo

@minggo minggo closed this as completed Jul 13, 2018
@minggo minggo removed this from the 3.18 milestone Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants