onEnterTransitionDidFinish and getRunningScene

[minggo]

Note

This issue is migrated from here. It was created at 2014/02/19 07:51:31 +0000

Description

When scene receives onEnterTransitionDidFinish() Director::getRunningScene() returns transition scene BUT not scene that was wrapped.
Current behavior is scene receive onEnterTransitionDidFinish in onExit of Transition, when transition is not finished and runningScene has not been updated yet.

Suggested fix:

--- a/cocos/2d/CCDirector.cpp
+++ b/cocos/2d/CCDirector.cpp
@@ -773,9 +773,12 @@ void Director::setNextScene()
_nextScene->retain();
_nextScene = nullptr;

• if ((! runningIsTransition) && _runningScene)
• if (_runningScene)
  {

•    _runningScene->onEnter();
  

•    if (!runningIsTransition)
  

•    {
  

•        _runningScene->onEnter();
  

•    }
   _runningScene->onEnterTransitionDidFinish();
  

  }
  }

--- a/cocos/2d/CCTransition.cpp
+++ b/cocos/2d/CCTransition.cpp
@@ -180,7 +180,7 @@ void TransitionScene::onExit()

 // _inScene should not receive the onEnter callback
 // only the onEnterTransitionDidFinish

• _inScene->onEnterTransitionDidFinish();
  +// _inScene->onEnterTransitionDidFinish();
  }

// custom cleanup

• Auhuro added comment:
  Is Duplicate of Bug pXmlBuffer is not null terminated #4073, please remove this one