refresh the search paths #11195
Closed
refresh the search paths #11195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumganhar
reviewed
Mar 3, 2017
| @@ -846,6 +846,7 @@ void FileUtils::setWritablePath(const std::string& writablePath) | |||
| void FileUtils::setDefaultResourceRootPath(const std::string& path) | |||
| { | |||
| _defaultResRootPath = path; | |||
| setSearchPaths(_searchPathArray); | |||
There was a problem hiding this comment.
Yep, good catch.
But i think this line
https://github.com/kpkhxlgy0/cocos2d-x/blob/e87207462912eef8235dfcab568eb4405a599002/cocos/platform/CCFileUtils.cpp#L857
will make the searchPaths parameter cleared.
We need to make a copy of searchPaths parameter before clear.
|
I submitted a new Pull Request (#17435) to fix this issue, it also resolves some other issues I found in FileUtils. Therefore, I closed this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I set the workdir in the command line on mac platform, it not affect the search paths, because the search paths set first, _defaultResRootPath is null string, so refresh the search paths can solve it.