[android] Include stdint.h for uint32_t in UIWebViewImpl-android.h #14727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Moskalchuk <dm@crystax.net>
|
While checking this pull request, Jenkins failed with error, not related to changes I did. It lost connection to ios runner. Android build was ok, so I suppose it's enough to accept this pull request. |
|
[ci rebuild] |
1 similar comment
|
[ci rebuild] |
|
@dmcrystax |
|
@dmcrystax duplicated with #14712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compilation error when building cocos2d-x demo by CrystaX NDK.
According to POSIX,
uint32_tis defined in "stdint.h", so if you use it in code, you should include "stdint.h".In Google's Android NDK it works because their "iosfwd" include "stdint.h" implicitly; however, it's not a requirement and you shouldn't rely on that.
With this fix, cocos2d-x demo getting built no matter which NDK is used - CrystaX or Google's one.