adds tvOS support #14808
Merged
adds tvOS support #14808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported tests: - js-tests - cpp-tsts - lua-tests - game-controller tests all of them working, but most of the tests can't be navigated since they expect a controller.
|
[ci rebuild] |
1 similar comment
|
[ci rebuild] |
| // to support different OS | ||
| // FileUtils::removeDirectory is subclassed on iOS/tvOS | ||
| // and system() is not available on tvOS | ||
| #if !defined(CC_PLATFORM_IOS) |
There was a problem hiding this comment.
@ricardoquesada why add this line since iOS and Mac implement FileUtils::removeDirectory in CCFileUtils-apple.cpp.
And the logic is error, because CC_PLATFORM_IOS is defined here.
There was a problem hiding this comment.
And i send #16062 to fix it.
|
@minggo probably a bug. thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported tests:
all of them working, but most of the tests can't be navigated
since they expect a controller.