fix downloader build issue for Android API 23 #15878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
List of java network libraries to pick from https://github.com/snowdream/awesome-android#network Personally I think okhttp has the best quality, but it is 300+ KB, 3 times as android-async-http 1.4.8 |
|
Thanks @cezheng . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15823
android-async-http 1.4.9 builds for API 23, but it introduces an external dependency, with a jar file of 1.1 MB.
Considering the fact that replacing libcurl with a java network library is to reduce the apk size, if this PR is merged, will the apk size still be smaller than using libcurl?
If not, we should consider another approach.
@minggo