fix: Label updateColor() and underline color work as expected #16486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Github issue cocos2d#15214 correctly. underline uses _displayColor and not _textColorF. _textColorF is only for the text. This also emulates the SystemFont underline behavior fixes Github issue cocos2d#16471
minggo
pushed a commit
to minggo/cocos2d-x
that referenced
this pull request
Sep 5, 2016
…d#16486) fixes Github issue cocos2d#15214 correctly. underline uses _displayColor and not _textColorF. _textColorF is only for the text. This also emulates the SystemFont underline behavior fixes Github issue cocos2d#16471
minggo
added a commit
that referenced
this pull request
Sep 7, 2016
* fix: Label updateColor() and underline color work as expected (#16486) fixes Github issue #15214 correctly. underline uses _displayColor and not _textColorF. _textColorF is only for the text. This also emulates the SystemFont underline behavior fixes Github issue #16471 * fix conflict * Issue 16471 (#16489) * fix: Label updateColor() and underline color work as expected fixes Github issue #15214 correctly. underline uses _displayColor and not _textColorF. _textColorF is only for the text. This also emulates the SystemFont underline behavior fixes Github issue #16471 * docs: added more internal doc for issue_16471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Github issue #15214 correctly. underline uses _displayColor
and not _textColorF. _textColorF is only for the text.
This also emulates the SystemFont underline behavior
fixes Github issue #16471