Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Cocos2dxHelper/CCFileUtils JNI fixes and improvements #1740

Merged
merged 2 commits into from Dec 10, 2012
Merged

[android] Cocos2dxHelper/CCFileUtils JNI fixes and improvements #1740

merged 2 commits into from Dec 10, 2012

Conversation

rtissera
Copy link
Contributor

@rtissera rtissera commented Dec 9, 2012

  • Added proper JNIEXPORT / JNICALL modifiers to Cocos2dxHelper
  • Rewrote CCFileUtils::getWriteabblePath() to get cache directory through Context.getCacheDir() Java method and wrote appropriate JNI bridge. This does fix a critical issue on Nexus 10 (CCUserDefault not working).

Romain TISSERAND added 2 commits December 9, 2012 13:44
…of Context.getCacheDir() through JNI callback instead. Needed in order to get CCUserDefault working fine on Nexus 10 (Androi 4.2 multi-user environment)
@minggo
Copy link
Contributor

minggo commented Dec 10, 2012

Thank you.

minggo added a commit that referenced this pull request Dec 10, 2012
[android] Cocos2dxHelper/CCFileUtils JNI fixes and improvements
@minggo minggo merged commit c933863 into cocos2d:gles20 Dec 10, 2012
@moadib
Copy link
Contributor

moadib commented Jan 29, 2013

I have note. Cache directory may be cleaned at any moment by system.

That mean that CCUserDefaults can be lost at any moment(if there is low space, then Android can delete files from apps cache dirs).

dumganhar pushed a commit that referenced this pull request Feb 22, 2013
fixed #1740: Added cleanup and reset methods to ScriptingCore.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
[android] Cocos2dxHelper/CCFileUtils JNI fixes and improvements
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
fixed cocos2d#1740: Added cleanup and reset methods to ScriptingCore.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
[android] Cocos2dxHelper/CCFileUtils JNI fixes and improvements
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
fixed cocos2d#1740: Added cleanup and reset methods to ScriptingCore.
minggo added a commit that referenced this pull request May 4, 2014
[android] Cocos2dxHelper/CCFileUtils JNI fixes and improvements
dumganhar pushed a commit that referenced this pull request May 4, 2014
fixed #1740: Added cleanup and reset methods to ScriptingCore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants