fixed #17989: touch stops responding on android devices. #18165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's caused by `FileUtils::getContents` is invoked in different threads and we use EventDispatcher::dispatchCustomEvent in `FileUtilsAndroid::getContents` to send an event to EngineDataManager. Since EngineDataManager class is only for internal use and EventDispatcher isn't thread-safe, we make `EngineDataManager::onBeforeReadFile` public and invoke it `FileUtilsAndroid::getContents`.
stevetranby
added a commit
to stevetranby/cocos2d-x
that referenced
this pull request
Aug 23, 2017
* commit 'e79f21cec02ebbffbf08150708ed26e524c1faf2': add new CMakeLists.txt to cpp-template-default (https://gist.github.com/MrCapone/ccdc1826cb7362086107e8096bfe6f90) (cocos2d#18167) Fixes compilation errors for android audio module while building with x86 arch. (cocos2d#18150) fixed GLViewImpl::getMonitorSize() for desktop platforms (cocos2d#18141) [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#18183) Fix android problem (cocos2d#18142) fix for ios audio engine (cocos2d#18146) fix android problem with 24 bit depth buffer on some devices (cocos2d#18148) Blend function for UIImageView (cocos2d#18149) Fix alpha blending during the animation of TransitionCrossFade. (cocos2d#18175) fixed cocos2d#17989: touch stops responding on android devices. (cocos2d#18165) [ci skip]update version and readme (cocos2d#18169) fix FontAtlas crash on some Android devices (cocos2d#18145) Add game-controller-test for win32 (cocos2d#18164) Fix android compile fail bug (cocos2d#18166) # Conflicts: # cocos/audio/android/cutils/bitops.h # cocos/audio/apple/AudioEngine-inl.mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's caused by
FileUtils::getContentsis invoked in different threads and we use EventDispatcher::dispatchCustomEvent inFileUtilsAndroid::getContentsto send an event to EngineDataManager.Since EngineDataManager class is only for internal use and EventDispatcher isn't thread-safe, we make
EngineDataManager::onBeforeReadFilepublic and invoke itFileUtilsAndroid::getContents.