[iOS] Fix edit box text are when caps lock is on #18738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drelaptop
reviewed
Jun 1, 2018
| float rightPadding = padding; | ||
| if(capsOn){ | ||
| // Need to pad rect on right to account for right image view | ||
| rightPadding = std::max(padding, (float)self.rightView.frame.size.width + RIGHT_VIEW_PADDING); |
There was a problem hiding this comment.
RIGHT_VIEW_PADDING should calc Scale, like CC_EDIT_BOX_PADDING did
float padding = CC_EDIT_BOX_PADDING * glview->getScaleX() / glview->getContentScaleFactor();
drelaptop
reviewed
Jun 1, 2018
|
|
||
| #define RIGHT_VIEW_PADDING 5.0f |
There was a problem hiding this comment.
RIGHT_VIEW_PADDING -> CAPS_LOCK_PADDING is better, since it's only change padding when caps lock is on
drelaptop
suggested changes
Jun 1, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #18739
New behavior