New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] add find_host_library into iOS toolchain file #19230

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@drelaptop
Collaborator

drelaptop commented Dec 4, 2018

  • you can use it like
find_host_library(Xamarin_LIB # var to save result
  NAMES Xamarin.iOS # Xamarin.iOS.framework
  PATHS ${CMAKE_CURRENT_SOURCE_DIR}/tmp) # libs dir

message(STATUS "Xamarin_LIB: ${Xamarin_LIB}") # print find libs result
  • the reason to add this is because iOS toolchain file changes the find_library default behavior by:
    set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)
@crazyhappygame

This comment has been minimized.

Contributor

crazyhappygame commented Dec 4, 2018

I think that we have to change (and simplify) this one iOS.toolchain to few iOS toolchains one per each configuration.

It should be similar to what was done for Android here https://github.com/cocos2d/cocos2d-x-external/blob/master/tools/android_arm64_v8a_toolchain.cmake

(Probably not in this code review, and we can do that as first in cocos2d-x-external)

@drelaptop drelaptop added this to the next milestone Dec 10, 2018

@drelaptop

This comment has been minimized.

Collaborator

drelaptop commented Dec 10, 2018

agree, we can try to simply iOS toolchain in cocos2d-x-external firstly.

@drelaptop drelaptop merged commit d8b838b into cocos2d:v3 Dec 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment