Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #19363 #19703

Closed
wants to merge 1 commit into from
Closed

fix for #19363 #19703

wants to merge 1 commit into from

Conversation

MrCapone
Copy link
Contributor

@MrCapone MrCapone commented May 13, 2019

@minggo
Copy link
Contributor

minggo commented May 14, 2019

It seems there is a conflict, could you please fix it, and could you please modify other templates too.

@MrCapone
Copy link
Contributor Author

MrCapone commented May 14, 2019

Done. I also updated the tests too.

@minggo
Copy link
Contributor

minggo commented May 15, 2019

@MrCapone have you tested it? @PatriceJiang told me it didn't take effect to modify like this. The warnings are gone, but the task was not executed.

@MrCapone
Copy link
Contributor Author

MrCapone commented May 15, 2019

I already using this code in my projects. Assets folder has been successfully generated and copied to apk. So nothing wrong with this line.
I'm using Android Studio version 3.4 with gradle plugin version 3.4.0.

@PatriceJiang
Copy link
Contributor

I tested the current v3 branch with similar changes and the files were not copied to the assets folder. @MrCapone would you please tell which version of gradle is used in your project?

@MrCapone
Copy link
Contributor Author

@PatriceJiang im using gradle plugin v3.4.0 which downloading gradle 5.1.1

@PatriceJiang
Copy link
Contributor

PatriceJiang commented May 15, 2019

It seems to be a bug of AndroidStudio I am using, which is perhaps too new.
The task is triggered correctly from the console, but it does not run in AndroidStudio.

It is caused by gradle version change.

@MrCapone
Copy link
Contributor Author

I've tested CppTest from main branch without this commit and then on my branch with it. In both cases assets folder didn't created and REsources didn't copied. So this commit has nothing to do with that issue. Anyway my project from cpp-template still working fine.

@PatriceJiang
Copy link
Contributor

The issue was introduced since #19657, we may choose another version of gradle or modify gradle build scripts. @MrCapone

@MrCapone
Copy link
Contributor Author

@PatriceJiang I've created empty project from my branch and tried build apk. Everything works fine. So gradle build scripts in cpp-template already working.

@minggo
Copy link
Contributor

minggo commented May 17, 2019

Because we need to copy resources, and it doesn't depend any other thing. So i think we can copy resources not using gradle task. Then it will not be affected by gradle.

@MrCapone
Copy link
Contributor Author

not relevant

@MrCapone MrCapone closed this May 23, 2019
@MrCapone MrCapone deleted the #19363 branch May 23, 2019 16:12
@hbSumrain
Copy link

Can you tell me how to resolve this problem ,it also happened to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants