Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a crash in iOS 9.3.5 when we have a layer with WebView getting deallocated #20285

Merged
merged 3 commits into from
Nov 14, 2019
Merged

Fixing a crash in iOS 9.3.5 when we have a layer with WebView getting deallocated #20285

merged 3 commits into from
Nov 14, 2019

Commits on Nov 1, 2019

  1. In case of iOS 9.3.5 when we show a web view and deallocate the layer… 

    … it is trying to release memory associated with WKWebView instance, but it hadn’t retained it in the first place. This results in a crash. This commit fixes that crash.
    @deepshah7
    deepshah7 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    2db8340 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. Removing the autorelease and retain parts from the WKWebView instanti… 

    …ation.
    @deepshah7
    deepshah7 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    a350e7d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Changes so that we can remove the retain from the property declaratio… 

    …n and depend only on manual retain and release of memory <Deep>
    @deepshah7
    deepshah7 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    ce765aa View commit details
    Browse the repository at this point in the history