Update CCPlatformConfig.h #20693
Merged
Update CCPlatformConfig.h #20693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With latest ndk23 there is no move ANDROID define. The correct way (before and now) is to use __ANDROID__ https://iq.opengenus.org/detect-operating-system-in-c/
|
What will happen if using lower NDK versions? |
Everything will work. Please check appveyor android build is green. BTW. Do you know what happen with Travis CI check? Only appveyor is running now. |
|
Sorry, i don't know Travis CI issue. |
|
@minggo could you merge it? |
stevetranby
added a commit
to stevetranby/cocos2d-x
that referenced
this pull request
Dec 18, 2021
* commit '64977e5aa21c6de22fd435ff96ce8eddcb57af40': Support python 2 and 3 (cocos2d#20698) Update CCPlatformConfig.h (cocos2d#20693)
stevetranby
added a commit
to stevetranby/cocos2d-x
that referenced
this pull request
Jul 20, 2022
* commit 'cd7446f17956d73041f9b33b37b4c747c6bc1993': Create pch for all platforms V3 (cocos2d#20705) Fix mac build V3 (cocos2d#20703) Setup github actions for V3 (cocos2d#20701) Support python 2 and 3 (cocos2d#20698) Update CCPlatformConfig.h (cocos2d#20693) # Conflicts: # cocos/audio/mac/CDAudioManager.m # cocos/audio/mac/CDXMacOSXSupport.h # cocos/scripting/js-bindings/CMakeLists.txt
rampr
pushed a commit
to hashcube/cocos2d-x
that referenced
this pull request
Sep 29, 2022
With latest ndk23 there is no move ANDROID define. The correct way (before and now) is to use __ANDROID__ https://iq.opengenus.org/detect-operating-system-in-c/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest ndk23 there is no more
ANDROIDdefine.The correct way (before and now) is to use
__ANDROID__https://iq.opengenus.org/detect-operating-system-in-c/