Added CCNotificationCenter::removeAllObservers(CCObject *target) #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a helper method that removes all observers with a particular target. It can be used in destuctors to ensure no observers trigger callbacks on objects that no longer exist.
| } | ||
|
|
||
| void NotificationCenterTest::toExtensionsMainLayer(cocos2d::CCObject* sender) | ||
| { | ||
| /* for testing removeAllObservers */ | ||
| int numObserversRemoved = CCNotificationCenter::sharedNotificationCenter()->removeAllObservers(this); | ||
| CCAssert(numObserversRemoved >= 3, "All observers were not removed!"); |
There was a problem hiding this comment.
"All observers were not removed!" ~> "All observers were removed!"
There was a problem hiding this comment.
The assert will trigger when numObserversRemoved < 3, which means there are still observers leftover and not all of them were removed. In that situation the debug message should say why the assert triggered, so the reason we give for the assert trigger is: "All observers were not removed!".
When all the observers are successfully removed the assertion does not trigger.
dumganhar
pushed a commit
that referenced
this pull request
Mar 11, 2013
fixed #1822: Added CCNotificationCenter::removeAllObservers(CCObject *target).
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
…or-target fixed cocos2d#1822: Added CCNotificationCenter::removeAllObservers(CCObject *target).
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
…or-target fixed cocos2d#1822: Added CCNotificationCenter::removeAllObservers(CCObject *target).
dumganhar
pushed a commit
that referenced
this pull request
May 4, 2014
fixed #1822: Added CCNotificationCenter::removeAllObservers(CCObject *target).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's more convenient to use this call in destructors so that all observers associated with a particular target are removed. This prevents crashes in case a developer forgets to remove all observers for their object before it is destroyed.