Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux] fixed font rendering crash for certain fonts #2271

Merged
merged 1 commit into from Mar 28, 2013
Merged

[Linux] fixed font rendering crash for certain fonts #2271

merged 1 commit into from Mar 28, 2013

Conversation

Weeds
Copy link
Contributor

@Weeds Weeds commented Mar 27, 2013

face->size->metrics->ascender seems to be unreliable for some fonts,
additionally the freetype documentation says that it may be used
differently for different fonts.
Therefore it may happen that the ascender of a font face is less then
the glyphs bounding box resulting in accessing invalid memory.

The fix is to use the bbox attribute instead of the ascender

@Weeds
[Linux] fixed font rendering crash for certain fonts
d0de78f 
face->size->metrics->ascender seems to be unreliable for some fonts,
additionally the freetype documentation says that it may be used
differently for different fonts.
Therefore it may happen that the ascender of a font face is less then
the glyphs bounding box resulting in accessing invalid memory.

The fix is to use the bbox attribute instead of the ascender
@Weeds Weeds mentioned this pull request Mar 28, 2013
Closed
@azmeuk
Copy link
Contributor

azmeuk commented Mar 28, 2013

Thanks, it fixes my issue!

dumganhar pushed a commit that referenced this pull request Mar 28, 2013
Merge pull request #2271 from Weeds/fontdimension-fix
0927570 
fixed #1932: [Linux] fixed font rendering crash for certain fonts.
@dumganhar dumganhar merged commit 0927570 into cocos2d:master Mar 28, 2013
@dumganhar
Copy link

Thank you.

@Weeds Weeds deleted the fontdimension-fix branch March 29, 2013 14:31
minggo added a commit to minggo/cocos2d-x that referenced this pull request Jun 9, 2013
@minggo
issue cocos2d#2271: fixed memory leak of CCControlColorPicker
a9216fb
minggo added a commit to minggo/cocos2d-x that referenced this pull request Jun 9, 2013
@minggo
issue cocos2d#2271: fixed memory leak of WebSocket
731cc3e
minggo added a commit to minggo/cocos2d-x that referenced this pull request Jun 9, 2013
@minggo
issue cocos2d#2271: fixed memory leak of CCTextureCache::snapshotText…
dd2699a 
…ures()
minggo added a commit to minggo/cocos2d-x that referenced this pull request Jun 9, 2013
@minggo
issue cocos2d#2271: fixed memory leak of CCControlColorPicker
a01df33
minggo added a commit to minggo/cocos2d-x that referenced this pull request Jun 9, 2013
@minggo
issue cocos2d#2271: fixed memory leak of WebSocket
3a3d7a5
minggo added a commit to minggo/cocos2d-x that referenced this pull request Jun 9, 2013
@minggo
issue cocos2d#2271: fixed memory leak of CCTextureCache::snapshotText…
7b4d7e4 
…ures()
dumganhar pushed a commit to dumganhar/cocos2d-x that referenced this pull request Jun 10, 2013
issue cocos2d#2271: Fixing some memory leaks.
38522de
dumganhar pushed a commit that referenced this pull request Jun 10, 2013
Merge pull request #2851 from dumganhar/master
d1d3ec5 
issue #2271: Fixing some memory leaks. [VS2012] Updating project dependence and warning fixes.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
Merge pull request cocos2d#2271 from Weeds/fontdimension-fix
8dbb9af 
fixed cocos2d#1932: [Linux] fixed font rendering crash for certain fonts.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCControlColorPicker
de6bda7
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
@minggo
issue cocos2d#2271: fixed memory leak of WebSocket
b1eab3e
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCTextureCache::snapshotText…
0c43017 
…ures()
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCControlColorPicker
9b1bb00
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
@minggo
issue cocos2d#2271: fixed memory leak of WebSocket
3c1b210
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCTextureCache::snapshotText…
9579d14 
…ures()
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
issue cocos2d#2271: Fixing some memory leaks.
e2d68b0
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
Merge pull request cocos2d#2851 from dumganhar/master
5dadd43 
issue cocos2d#2271: Fixing some memory leaks. [VS2012] Updating project dependence and warning fixes.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
Merge pull request cocos2d#2271 from Weeds/fontdimension-fix
187fd79 
fixed cocos2d#1932: [Linux] fixed font rendering crash for certain fonts.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCControlColorPicker
5f67bab
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
@minggo
issue cocos2d#2271: fixed memory leak of WebSocket
ad74c1b
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCTextureCache::snapshotText…
34d7631 
…ures()
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCControlColorPicker
26cac9d
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
@minggo
issue cocos2d#2271: fixed memory leak of WebSocket
579a648
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCTextureCache::snapshotText…
8809512 
…ures()
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
issue cocos2d#2271: Fixing some memory leaks.
dff9e10
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
Merge pull request cocos2d#2851 from dumganhar/master
289de7d 
issue cocos2d#2271: Fixing some memory leaks. [VS2012] Updating project dependence and warning fixes.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCControlColorPicker
1d673e5
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
@minggo
issue cocos2d#2271: fixed memory leak of WebSocket
0ddb57d
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCTextureCache::snapshotText…
2d6b039 
…ures()
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCControlColorPicker
c4ab295
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
@minggo
issue cocos2d#2271: fixed memory leak of WebSocket
1a0789c
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
@minggo
issue cocos2d#2271: fixed memory leak of CCTextureCache::snapshotText…
c84a071 
…ures()
dumganhar pushed a commit that referenced this pull request May 4, 2014
Merge pull request #2271 from Weeds/fontdimension-fix
32cee20 
fixed #1932: [Linux] fixed font rendering crash for certain fonts.
minggo added a commit that referenced this pull request May 4, 2014
@minggo
issue #2271: fixed memory leak of CCControlColorPicker
f00baac
minggo added a commit that referenced this pull request May 4, 2014
@minggo
issue #2271: fixed memory leak of WebSocket
81b579c
minggo added a commit that referenced this pull request May 4, 2014
@minggo
issue #2271: fixed memory leak of CCTextureCache::snapshotTextures()
ec7bf7a
dumganhar pushed a commit that referenced this pull request May 4, 2014
issue #2271: Fixing some memory leaks.
a14df8d
dumganhar pushed a commit that referenced this pull request May 4, 2014
Merge pull request #2851 from dumganhar/master
e9f3913 
issue #2271: Fixing some memory leaks. [VS2012] Updating project dependence and warning fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Weeds @azmeuk @dumganhar