Pitch 7platforms

[sergey-shambir]

• Implemented pitch, pan and gain for 7 platforms: iOS, OSX, android (both backends), linux (both backends), tizen, blackberry, nacl. Last 4 platforms now have unified OpenAL engine.
• No support for windows, emscrippten, marmalade, no pitch effect on android+OpenSL since bug in OpenSL at android >= 4.0 requires some redesign: http://code.google.com/p/android/issues/detail?id=24592
• OpenAL engine on Linux now have optional mp3 support, with OPENAL_MP3=1 make option. When option enabled, cocos dynamically linked with libmpg123 (LGPL licensed).
• Reorganized CocosDenshionTest, added sliders for pitch/pan/gain.

Should work on NaCL and Blackberry, but I didn't tested. Tested on android, linux, tizen emulator; implementations for iOS/OSX are trivial and used in our cocos2d-x tweak, but I didn't tested TestCpp separately.

About unsupported features:

• I'm going to add pitch support for Android+OpenES soon, maybe on near weekend
• On emscrippten pitch cannot be implemented using SDL, but emscrippten now supports OpenAL so we can use unified openal engine on this platform too. But this feature needs extensive testing, since OpenAL on emscrippten have own javascript backend and I don't know which audio codecs are supported by javascript-based alut.
• On windows, there are some work in another pull requests that can help to impelemnt pitch/pan/gain, so we just need wait while this work will be finished.
• On marmalade stereo effects and pitch are hurd to implement, but maybe marmalade stuff can do it.

[metalpasman]

I will include support for pitch/pan/gain in win32 refactoring

[sergey-shambir]

Thanks. Also check that in win32 OpenAL backend rewindBackgroundMusic() will not stop music, this function should just return player to music start.

[metalpasman]

Yes, I fixed rewindBackgroundMusic() yet a little different than the linux approach:

This is what you have:

    void SimpleAudioEngine::rewindBackgroundMusic()
    {
        ALint state;
        alGetSourcei(s_backgroundSource, AL_SOURCE_STATE, &state);
        if (state == AL_PLAYING)
        {
            alSourceRewind(s_backgroundSource);
            alSourcePlay(s_backgroundSource);
        }
        checkALError("rewindBackgroundMusic:alSourceRewind");
    }

This is what I've implemented:

    void SimpleAudioOpenAL::resumeBackgroundMusic()
    {
        ALint state;
        alGetSourcei(s_backgroundSource, AL_SOURCE_STATE, &state);
        if (state == AL_PAUSED || state == AL_INITIAL)
            alSourcePlay(s_backgroundSource);
        checkALError("resumeBackgroundMusic:alSourcePlay");
    } 

    void SimpleAudioOpenAL::rewindBackgroundMusic()
    {
        ALint state;
        alGetSourcei(s_backgroundSource, AL_SOURCE_STATE, &state);
        alSourceRewind(s_backgroundSource);
        if (state == AL_PLAYING)
            alSourcePlay(s_backgroundSource);
        checkALError("rewindBackgroundMusic:alSourceRewind");
    }

The difference is that I can rewind also when paused, but I had to change resumeBackgroundMusic method to also resume initial state. This means even if you have not started the background music play you can resume it.

Which approach should I consider?

[sergey-shambir]

Your approach is better. But maybe rewindBackgroundMusic can also check that state == AL_PAUSED, and play->pause music at this case, so no changes in resumeBackgroundMusic required.

[sergey-shambir]

A bit hard to say where is problem, but I'll try to fix build tomorrow.

[ricardoquesada]

this looks like a nice feature.
We need a better sound engine for cocos2d v3.0, and these additions looks good! (I haven't tested the patch, but from the description, they are very welcome additions)

@minggo @dumganhar
Any plans to include this feature in cocos2d-x ? Thanks.

[minggo]

Thanks @sergey-shambir.

@ricardoquesada
Yep, it is a nice feature. We will merge it after testing.

[sergey-shambir]

Oops... I've made wrong update, will fix it soon.

UPD: fixed

[minggo]

@sergey-shambir
But there is not new commit.

[sergey-shambir]

Yes, I've removed it with "push origin -f"

[minggo]

Thanks @sergey-shambir, the test looks great.
I fixed conflict in #3108.