Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware keyboard support (Windows support + Mac fix) #3054

Merged
merged 4 commits into from
Jul 4, 2013
Merged

Hardware keyboard support (Windows support + Mac fix) #3054

merged 4 commits into from
Jul 4, 2013

Conversation

reneklacan
Copy link
Contributor

Added Windows support for HW keyboard (as addition to #2704) and also included fix for Mac.

@dumganhar
Copy link

Could you pull the latest codes?

@reneklacan
Copy link
Contributor Author

sure, done :)

@@ -449,6 +452,9 @@ LRESULT EGLView::WindowProc(UINT message, WPARAM wParam, LPARAM lParam)
}
break;
case WM_KEYDOWN:
#ifdef KEYBOARD_SUPPORT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have renamed KEYBOARD_SUPPORT to CC_ KEYBOARD_SUPPORT.
Do you mind to change it to CC_ KEYBOARD_SUPPORT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, I will change that :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@reneklacan
Copy link
Contributor Author

also please consider merge of #2776

@minggo
Copy link
Contributor

minggo commented Jul 4, 2013

Thanks @simpliplant.
I have asked @boyu0 to review #2776.

minggo added a commit that referenced this pull request Jul 4, 2013
Hardware keyboard support (Windows support + Mac fix)
@minggo minggo merged commit 766154a into cocos2d:develop Jul 4, 2013
@rishftw
Copy link

rishftw commented Jul 19, 2013

okay guys, I'm really a big noob, so sorry, but how do i use only the cross-platform keyboard feature, without using the develop brach? like, can i just add the keyboard part to cocos2d-x 2.1.4?
I don't wanna use the develop branch cuz I'm guessing there are problems?:/
thanks

angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
…port

Hardware keyboard support (Windows support + Mac fix)
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
…port

Hardware keyboard support (Windows support + Mac fix)
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
…port

Hardware keyboard support (Windows support + Mac fix)
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
…port

Hardware keyboard support (Windows support + Mac fix)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants