close #3835:fix TMXMapInfo::startElement insert property to properties fail. #5210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -250,7 +250,8 @@ class CC_DLL TMXMapInfo : public Object, public SAXDelegator | |||
| inline void setStoringCharacters(bool storingCharacters) { _storingCharacters = storingCharacters; }; | |||
|
|
|||
| /// properties | |||
| inline ValueMap getProperties() const { return _properties; }; | |||
| inline const ValueMap& getProperties() const { return _properties; } | |||
| inline ValueMap& getProperties() { return _properties; } | |||
| inline void setProperties(ValueMap properties) { | |||
There was a problem hiding this comment.
Please add const ValueMap& for setters. Thanks.
minggo
added a commit
that referenced
this pull request
Jan 24, 2014
close #3835:fix TMXMapInfo::startElement insert property to properties fail.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
close cocos2d#3835:fix TMXMapInfo::startElement insert property to properties fail.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
close cocos2d#3835:fix TMXMapInfo::startElement insert property to properties fail.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
close cocos2d#3835:fix TMXMapInfo::startElement insert property to properties fail.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
close cocos2d#3835:fix TMXMapInfo::startElement insert property to properties fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.