Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closed #4428: fixed display incorrect of multi-line label if invoking 'getLetter' #5843

Merged
merged 5 commits into from Mar 19, 2014

Conversation

WenhaiLin
Copy link
Contributor

No description provided.

@dumganhar
Copy link

Please add a test case to reproduce this bug. Thanks.

/* This is the opposite of "addQuadFromSprite.
It add the sprite to the children and descendants array, but it doesn't update add it to the texture atlas
*/
SpriteBatchNode * addSpriteWithoutQuad(Sprite *child, int z, int aTag);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to make this method public?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I saw Label::getLetter needs it.

@dumganhar dumganhar changed the title closed issue#4428:fixed label display incorrect if invoking getLetter and it's multi-line. closed #4428: fixed display incorrect of multi-line label if invoking 'getLetter' Mar 19, 2014
dumganhar pushed a commit that referenced this pull request Mar 19, 2014
closed #4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
@dumganhar dumganhar merged commit d1b0c20 into cocos2d:develop Mar 19, 2014
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 28, 2014
closed cocos2d#4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 29, 2014
closed cocos2d#4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
closed cocos2d#4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
angeltown pushed a commit to angeltown/cocos2d-x that referenced this pull request Apr 30, 2014
closed cocos2d#4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants