New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closed #4428: fixed display incorrect of multi-line label if invoking 'getLetter' #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add a test case to reproduce this bug. Thanks. |
/* This is the opposite of "addQuadFromSprite. | ||
It add the sprite to the children and descendants array, but it doesn't update add it to the texture atlas | ||
*/ | ||
SpriteBatchNode * addSpriteWithoutQuad(Sprite *child, int z, int aTag); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to make this method public
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I saw Label::getLetter
needs it.
dumganhar
changed the title
closed issue#4428:fixed label display incorrect if invoking getLetter and it's multi-line.
closed #4428: fixed display incorrect of multi-line label if invoking 'getLetter'
Mar 19, 2014
dumganhar
pushed a commit
that referenced
this pull request
Mar 19, 2014
closed #4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 28, 2014
closed cocos2d#4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 29, 2014
closed cocos2d#4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
closed cocos2d#4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
angeltown
pushed a commit
to angeltown/cocos2d-x
that referenced
this pull request
Apr 30, 2014
closed cocos2d#4428: fixed display incorrect of multi-line label if invoking 'getLetter'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.