Implemented PLUSARGS for FLI #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you use |
|
Don't merge just yet, need to update newsfragment to right PR and add some deallocation. @eric-wieser That seems like it would work, I'll try it. |
eric-wieser
reviewed
Feb 19, 2020
ktbarrett
force-pushed
the
questa_plusargs
branch
2 times, most recently
from
88f927f
to
e224169
Compare
themperek
approved these changes
Feb 20, 2020
eric-wieser
reviewed
Feb 20, 2020
eric-wieser
reviewed
Feb 20, 2020
eric-wieser
reviewed
Feb 20, 2020
eric-wieser
reviewed
Feb 20, 2020
eric-wieser
reviewed
Feb 20, 2020
eric-wieser
reviewed
Feb 20, 2020
The FLI does not offer any utility to easily grab the argc/argv from the simulator. I use Questa's included TCL interpreter C API to access the TCL 'argv' variable. The 'argv' variable references the outer vsim call's arguments due to how the current makefiles are setup, so the PLUSARGS variable was added back to the outer call. PLUSARGS must also remain on the inner call for the VPI implementation to work.
ktbarrett
force-pushed
the
questa_plusargs
branch
from
e224169
to
2d654ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed version of b283b48. Uses
Tcl_GetStringResultinstead of accessing the internalresultfield, this works on TCL 8.5 and 8.6. Fixes #1404.Finally got 2019.1 setup and tested this PR against it as well as 10.5c and 10.7c.
I tried using
Tcl_GetVar2Exto grab a reference toargv, then do processing on it, but there is something weird about how Questa maintains its TCL interpreter because it returns a message that the variable isn't defined.mti_Cmdseems to work.