Deprecating cocotb.generators and Scoreboard #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must use conda on Windows to build the cocotb package for CI. We shouldn't have Travis source a python installation because we aren't using it.
ktbarrett
added
the
type:deprecation
Codecov Report
@@ Coverage Diff @@
## master #2047 +/- ##
==========================================
+ Coverage 64.20% 64.23% +0.03%
==========================================
Files 34 34
Lines 4724 4728 +4
Branches 816 816
==========================================
+ Hits 3033 3037 +4
Misses 1380 1380
Partials 311 311
Continue to review full report at Codecov.
|
ktbarrett
added a commit
to ktbarrett/cocotb
that referenced
this pull request
Sep 5, 2020
cmarqu
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases #2041 on master. It deprecates everything in the
cocotb.generatorspackage, and thecocotb.scoreboard.Scoreboard. It must also update the tests and examples that use the deprecated feature.