added plusargs support for ghdl

[gigo333]

When using ghdl -r some arguments (like vhdl version) must be passed after the top defnition while others must be passed after the vpi arguments (like --wave).
Now when using the plusargs optional arguments, this argument will be passed after the vpi args , while the test_args arguments will be passed after the top module declaration.

[imphil]

@themperek Can you have a look to see if we need additional tests for plusarg support?

[themperek]

@themperek Can you have a look to see if we need additional tests for plusarg support?

Yes. On the way actually.

[themperek]

@gigo333 Would you like to to add a test for this?

It should be similar way than https://github.com/cocotb/cocotb/blob/master/tests/pytest/test_vhdl_libraries_multiple.py
Makefile version is here: https://github.com/cocotb/cocotb/blob/master/tests/test_cases/test_plusargs/Makefile + https://github.com/cocotb/cocotb/blob/master/tests/designs/plusargs_module/Makefile

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@8fef13a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 468609b differs from pull request most recent head 58a370c. Consider uploading reports for the commit 58a370c to get more accurate results

@@            Coverage Diff            @@
##             master    #3214   +/-   ##
=========================================
  Coverage          ?   68.04%           
=========================================
  Files             ?       48           
  Lines             ?     8824           
  Branches          ?     2428           
=========================================
  Hits              ?     6004           
  Misses            ?     2458           
  Partials          ?      362           

Impacted Files	Coverage Δ
cocotb/runner.py	28.96% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gigo333]

I'm sorry, @themperek, i don't have much time now to write the tests.

[ktbarrett]

I think this is fine without a test, plusargs support was added to all the other simulators without a test and it existed in the Makefiles previously. @gigo333 There have been changes to the runner file since you've pushed this PR and there are conflicts. Do you have time to resolve the conflicts at least?

[gigo333]

@ktbarrett I have resolved the conflicts.

[ktbarrett]

It appears to still be in conflict. I'm not sure why... My guess is that you need to rebase your branch onto master. cocotb uses rebasing for PRs and I'm guessing while you merged to a clean working point, it won't rebase cleanly, for whatever reason. Are you familiar and comfortable with rebasing? If not, here is some documentation.

[ktbarrett]

@themperek You okay with this?

[themperek]

@gigo333 Thank you!