Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some things private #3672

Merged
merged 2 commits into from Jan 22, 2024
Merged

Make some things private #3672

merged 2 commits into from Jan 22, 2024

Conversation

ktbarrett
Copy link
Member

See title.

@ktbarrett ktbarrett requested a review from a team January 20, 2024 22:29
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4b32fb9) 68.91% compared to head (efc4eb4) 68.91%.
Report is 4 commits behind head on master.

Files Patch % Lines
src/cocotb/regression.py 75.00% 0 Missing and 1 partial ⚠️
src/cocotb/scheduler.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3672   +/-   ##
=======================================
  Coverage   68.91%   68.91%           
=======================================
  Files          46       46           
  Lines        8561     8561           
  Branches     2439     2439           
=======================================
  Hits         5900     5900           
  Misses       1519     1519           
  Partials     1142     1142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktbarrett ktbarrett changed the title Make xunit reporter private Make some things private Jan 20, 2024
docs/source/newsfragments/3672.change.2.rst Outdated Show resolved Hide resolved
@ktbarrett ktbarrett merged commit e9f745e into cocotb:master Jan 22, 2024
25 checks passed
@ktbarrett ktbarrett deleted the private-xunit branch January 22, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants