Cleanup LogicArray interface #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktbarrett
force-pushed
the
logic-array-iface
branch
4 times, most recently
from
a1c2f6a
to
a5b36c4
Compare
ktbarrett
force-pushed
the
logic-array-iface
branch
from
a5b36c4
to
89f63fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3792 +/- ##
==========================================
+ Coverage 73.54% 73.61% +0.07%
==========================================
Files 49 49
Lines 7916 7941 +25
Branches 2195 2215 +20
==========================================
+ Hits 5822 5846 +24
- Misses 1581 1591 +10
+ Partials 513 504 -9 ☔ View full report in Codecov by Sentry. |
ktbarrett
force-pushed
the
logic-array-iface
branch
from
89f63fc
to
cdaaaf4
Compare
cmarqu
reviewed
Mar 20, 2024
ktbarrett
force-pushed
the
logic-array-iface
branch
from
cdaaaf4
to
2e4cca5
Compare
cmarqu
approved these changes
Mar 21, 2024
ktbarrett
force-pushed
the
logic-array-iface
branch
from
2e4cca5
to
7e55ffd
Compare
imphil
approved these changes
Apr 7, 2024
* Deprecate LogicArray.integer, .signed_integer, and .binstr * Deprecate constructing LogicArray from ints. * Introduce LogicArray.from_unsigned, from_signed, to_signed, and to_unsigned to replace what was deprecated.
ktbarrett
force-pushed
the
logic-array-iface
branch
from
7e55ffd
to
e7a0242
Compare
marlonjames
reviewed
Apr 7, 2024
ktbarrett
force-pushed
the
logic-array-iface
branch
from
92ea450
to
316b801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3660. Closes #3418.
LogicArray.integer,.signed_integer, and.binstrLogicArrayfrom ints.LogicArray.from_unsigned,.from_signed,.to_signed, and.to_unsignedto replace what was deprecated.If we need other kinds of construction/conversion, we can add them later.