Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break reference cycles in the edge triggers #727

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Break reference cycles in the edge triggers #727

merged 2 commits into from
Dec 17, 2018

Commits on Dec 16, 2018

  1. Remove the _Edge base class from ClockCycles 

    Rationale:
* ClockCycles shares only one line of implementation with _Edge, and it's easier just to repeat it.
* ClockCycles doesn't make much sense as a subclass of _Edge
* _Edge is private anyway, so no consumer of the public API will care
    @eric-wieser
    eric-wieser committed Dec 16, 2018
    Configuration menu
    Copy the full SHA
    48064bd View commit details
    Browse the repository at this point in the history

  2. Break reference cycles in the edge triggers 

    Previously there was a cyclic reference between `Signal._r_edge -> _Edge.signal -> ...`

This takes the same approach as 94eeaba,
using a weak dictionary to ensure edges keep their signal alive, but not
vice versa.
    @eric-wieser
    eric-wieser committed Dec 16, 2018
    Configuration menu
    Copy the full SHA
    435f7c9 View commit details
    Browse the repository at this point in the history