Remove the Trigger base class from Event and Lock #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These objects are not triggers - they cannot be yielded as their `prime` method takes too many arguments. Instead, they have methods which return triggers - `Event` is used as `yield event.wait()`, and `Lock` is used as `yield lock.acquire()`.
eric-wieser
force-pushed
the
Event-is-not-a-trigger
branch
from
3cc6d25
to
e0a143f
Compare
|
FIXME removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These objects are not triggers - they cannot be yielded as their
primemethod takes too many arguments.Instead, they have methods which return triggers -
Eventis used asyield event.wait(), andLockis used asyield lock.acquire().