Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests about assertions #272

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Improve tests about assertions #272

merged 1 commit into from
Oct 5, 2020

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the assertSame to replace assertEquals and it can make assert equals checking strict.

kubawerlos
kubawerlos suggested changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add php_unit_strict rule to .php_cs - will prevent using assertEquals in the future.

@florianeckerstorfer florianeckerstorfer merged commit 419ea11 into cocur:master Oct 5, 2020
@peter279k peter279k deleted the test_enhancement branch October 5, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawerlos kubawerlos kubawerlos requested changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peter279k @OskarStark @kubawerlos @florianeckerstorfer