Corrected rules for Danish special letters 'ø' and 'å' #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Can you fix the broken test before I merge this? |
|
Sure thing. |
|
@florianeckerstorfer |
florianeckerstorfer
pushed a commit
that referenced
this pull request
Sep 29, 2015
Fix rules for Danish special letters 'ø' and 'å'
|
Thank you very much for your contribution. |
|
My pleasure :) Thanks for taking the time to implement and maintain this! |
bobdenotter
added a commit
to bolt/bolt
that referenced
this pull request
Sep 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Danish, we have the three special letters: "æ", "ø", and "å".
The rule/interface for "æ" is currently correct, turning the letter into "ae". However, the conversion is wrong for "ø" and "å", since these should also be converted into two letters.
This two-letter configuration is essential for readability and word spellings. A Danish word like "bør" (means "should") should become "boer". Currently, the word becomes "bor", which in Danish means "drill" or "lives".
This pull request corrects this disparity.