Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Document duplication options for PMD CPD #670

Merged
merged 11 commits into from
Oct 26, 2021
Merged

Conversation

mrfyda
Copy link
Contributor

@mrfyda mrfyda commented May 14, 2021

hey @prcr
I saw someone asking about this in chat and thought I'd contribute.

It's been a long time and I haven't tested this, but it looks like the code is still there.

@mrfyda mrfyda requested a review from prcr May 14, 2021 10:37
@github-actions

This comment has been minimized.

@prcr
Copy link
Contributor

prcr commented May 14, 2021

hey @prcr
I saw someone asking about this in chat and thought I'd contribute.

It's been a long time and I haven't tested this, but it looks like the code is still there.

@mrfyda this is a great contribution and looks very interesting! Do you have a suggestion on how we could test these settings? Perhaps with one of Codacy's repositories? 🤔

@prcr prcr changed the title docs: Document duplication options feature: Document duplication options for PMD CPD May 18, 2021
@netlify
Copy link

netlify bot commented Oct 21, 2021

✔️ Deploy Preview for docs-codacy ready!

🔨 Explore the source changes: c06ff53

🔍 Inspect the deploy log: https://app.netlify.com/sites/docs-codacy/deploys/6176d86cb6ea0500083312e9

😎 Browse the preview: https://deploy-preview-670--docs-codacy.netlify.app/repositories-configure/codacy-configuration-file

@prcr prcr force-pushed the duplication-settings branch 2 times, most recently from 48e4e72 to f871ff6 Compare October 22, 2021 11:52
Paulo Ribeiro added 4 commits October 22, 2021 14:44
As the page grows bigger, the sentence becomes easier to find at the
bottom of the page. Besides that, all documentation pages already
include the Support contact information in the feedback block.
@prcr prcr marked this pull request as ready for review October 22, 2021 13:49
@prcr prcr requested a review from a team as a code owner October 22, 2021 13:49
@prcr
Copy link
Contributor

prcr commented Oct 22, 2021

@prcr prcr requested review from machadoit, pedrocodacy and franciscodua and removed request for machadoit October 22, 2021 14:16
@prcr prcr requested a review from IGFCoimbra October 25, 2021 14:08
@pedrocodacy
Copy link
Contributor

nice 💪

@prcr prcr merged commit 4ceb4db into master Oct 26, 2021
@prcr prcr deleted the duplication-settings branch October 26, 2021 11:52
prcr pushed a commit that referenced this pull request Oct 28, 2021
@prcr
Copy link
Contributor

prcr commented Oct 28, 2021

I reverted the changes from this pull request (#906) because it appears that Codacy doesn't read and apply the Configuration file options to control duplication. See CY-5184.

prcr pushed a commit that referenced this pull request Oct 28, 2021
prcr pushed a commit that referenced this pull request Oct 28, 2021
prcr pushed a commit that referenced this pull request Oct 28, 2021
prcr pushed a commit that referenced this pull request Jan 31, 2022
This documentation was initially added on #670
but was later reverted on #906
because the Codacy configuration file settings weren't working.
prcr pushed a commit that referenced this pull request Feb 2, 2022
* feature: Document duplication options for PMD CPD

This documentation was initially added on #670
but was later reverted on #906
because the Codacy configuration file settings weren't working.

* clean: Link intro to tool-specific configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants