Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored dependencies #15

Merged
merged 1 commit into from May 23, 2016
Merged

Update vendored dependencies #15

merged 1 commit into from May 23, 2016

Conversation

snikch
Copy link
Contributor

@snikch snikch commented May 23, 2016

This updates the Godeps directory with the current master version of all dependencies. This builds and tests pass.

It should be noted that best practice for libraries is to not include vendored dependencies in the vcs as this causes headaches when resolving dep trees. Since this is both a library and an executable, it would make sense for the vendored files to be in the cmd/sneaker lib.

@snikch
Copy link
Contributor Author

snikch commented May 23, 2016

Tests pass locally. I'm sitting here nervously looking at that Travis yellow dot.

@codahale codahale merged commit 3e52e64 into codahale:master May 23, 2016
@codahale
Copy link
Owner

Sneaker is a CLI tool first and only incidentally a library, hence the vendored deps. Thanks for the PR.

@snikch
Copy link
Contributor Author

snikch commented May 23, 2016

Fair enough, and thanks for the tool. I think I'm using it in a way not quite as you'd intended, but you should know it works very well as a library too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants