Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused code #97

Open
code423n4 opened this issue Apr 21, 2021 · 2 comments
Open

Unused code #97

code423n4 opened this issue Apr 21, 2021 · 2 comments
Labels
0 (Non-critical) bug Something isn't working sponsor acknowledged

Comments

@code423n4
Copy link
Contributor

Handle

paulius.eth

Vulnerability details

Vulnerability details

unused variable in Pool contract:
uint8 public constant DL_FACTORY = 1; // Factory type of DebtLockerFactory.
Also unused event in MapleTreasury contract:
event FundsTokenModified(address by, address newFundsToken);
Unused code provokes doubts about its intended use.

Recommended Mitigation Steps

Remove unused code to make it more readable and consume less gas.
@code423n4 code423n4 added 1 (Low Risk) bug Something isn't working labels Apr 21, 2021
code423n4 added a commit that referenced this issue Apr 21, 2021
@code423n4
paulius.eth issue #97
83c1f82
@lucas-manuel
Copy link
Collaborator

Informational, will address

@lucas-manuel
Copy link
Collaborator

Not going to address, might need for future DLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) bug Something isn't working sponsor acknowledged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Arachnid @lucas-manuel @code423n4