Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing access restriction on lockUnits/unlockUnits #208

Open
code423n4 opened this issue Apr 28, 2021 · 1 comment
Open

Missing access restriction on lockUnits/unlockUnits #208

code423n4 opened this issue Apr 28, 2021 · 1 comment
Labels
3 (High Risk) bug Something isn't working filed This issue has been filed in the main repo. sponsor confirmed

Comments

@code423n4
Copy link
Collaborator

Handle

@cmichelio

Vulnerability details

Vulnerability Details

The Pool.lockUnits allows anyone to steal pool tokens from a member and assign them to msg.sender.

Impact

Anyone can steal pool tokens from any other user.

Recommended Mitigation Steps

Add access control and require that msg.sender is the router or another authorized party.
@code423n4 code423n4 added 3 (High Risk) bug Something isn't working labels Apr 28, 2021
code423n4 added a commit that referenced this issue Apr 28, 2021
@code423n4
@cmichelio issue #208
618c71e
@strictly-scarce
Copy link
Collaborator

Valid, although this is part of the partially-complete lending code.

@0xBrian 0xBrian mentioned this issue Apr 29, 2021
Closed
@0xBrian 0xBrian added the filed This issue has been filed in the main repo. label Apr 29, 2021
This was referenced May 1, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) bug Something isn't working filed This issue has been filed in the main repo. sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xBrian @strictly-scarce @code423n4