Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add anchor map #236

Open
code423n4 opened this issue Apr 28, 2021 · 1 comment
Open

Add anchor map #236

code423n4 opened this issue Apr 28, 2021 · 1 comment
Labels
addressed bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Collaborator

Handle

@cmichelio

Vulnerability details

Router.updateAnchorPrice iterates over all anchor tokens on each update which is very inefficient and does a lot of expensive storage loads. add a mapping address => index to easily retrieve the index of the token in the arrayAnchors mapping.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 28, 2021
code423n4 added a commit that referenced this issue Apr 28, 2021
@code423n4
@cmichelio issue #236
c75627d
@0xBrian
Copy link
Collaborator

0xBrian commented May 11, 2021

vetherasset/vaderprotocol-contracts@452986a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addressed bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xBrian @code423n4