Skip to content

Issues: code-423n4/2021-05-nftx-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

42 Open 81 Closed
42 Open 81 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Using calldata when not appropiate 0 (Non-critical) bug Something isn't working Disputed
#100 opened May 11, 2021 by code423n4
2
Revert inside a loop Acknowledged bug Something isn't working G (Gas Optimization)
#97 opened May 11, 2021 by code423n4
1
Two Duplicate "rescueTokens" Functions In NFTXFeeDistributor 0 (Non-critical) bug Something isn't working Confirmed duplicate This issue or pull request already exists
#91 opened May 11, 2021 by code423n4
Incorrect Type Specified For Argument _address In NFTXFeeDistributor.rescueTokens() 0 (Non-critical) bug Something isn't working Confirmed
#89 opened May 11, 2021 by code423n4
NFTXLPStaking Is Subject To A Flash Loan Attack That Can Steal Nearly All Rewards/Fees That Have Accrued For A Particular Vault 3 (High Risk) bug Something isn't working Disputed
#88 opened May 11, 2021 by code423n4
4
Upgradeable contracts not Upgradeable 1 (Low Risk) bug Something isn't working Disputed
#87 opened May 11, 2021 by code423n4
2
__Ownable_init will be called twice in multiple Eligibility contracts 1 (Low Risk) bug Something isn't working Confirmed
#84 opened May 11, 2021 by code423n4
lack of zero address validation 1 (Low Risk) bug Something isn't working Confirmed
#82 opened May 11, 2021 by code423n4
Missing pool existence check in balanceOf 1 (Low Risk) bug Something isn't working Confirmed
#80 opened May 11, 2021 by code423n4
Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom 2 (Med Risk) bug Something isn't working Confirmed
#79 opened May 11, 2021 by code423n4
Randomization of NFTs returned in redeem/swap operations can be brute-forced 2 (Med Risk) Acknowledged bug Something isn't working
#78 opened May 11, 2021 by code423n4
1
Front-running setFees() could avoid fees 1 (Low Risk) bug Something isn't working Confirmed
#72 opened May 11, 2021 by code423n4
The direct redeem fee can be circumvented 2 (Med Risk) Acknowledged bug Something isn't working
#71 opened May 11, 2021 by code423n4
1
A malicious receiver can cause another receiver to lose out on distributed fees by returning false for tokensReceived when receiveRewards is called on their receiver contract. 2 (Med Risk) bug Something isn't working Confirmed
#69 opened May 11, 2021 by code423n4
1
Change function visibility from public to external bug Something isn't working Confirmed G (Gas Optimization)
#64 opened May 11, 2021 by code423n4
Unused events bug Something isn't working Confirmed duplicate This issue or pull request already exists G (Gas Optimization)
#63 opened May 11, 2021 by code423n4
Unused storage variables Acknowledged bug Something isn't working Confirmed G (Gas Optimization)
#62 opened May 11, 2021 by code423n4
Semantic Overloading in NFTXUpgradable.sol 0 (Non-critical) bug Something isn't working Confirmed duplicate This issue or pull request already exists
#61 opened May 11, 2021 by code423n4
Tokens can get stuck in NFTXMintRequestEligibility 2 (Med Risk) bug Something isn't working Confirmed
#59 opened May 11, 2021 by code423n4
Potential bug with reverseEligOnRedeem / misleading name 1 (Low Risk) bug Something isn't working Confirmed
#57 opened May 11, 2021 by code423n4
getRandomTokenIdFromFund yields wrong probabilities for ERC1155 3 (High Risk) Acknowledged bug Something isn't working duplicate This issue or pull request already exists
#56 opened May 11, 2021 by code423n4
2
Vault's flash loan not implemented according to EIP-3156 1 (Low Risk) bug Something isn't working Confirmed
#54 opened May 11, 2021 by code423n4
1
Vault's swapTo can return the input tokens 1 (Low Risk) Acknowledged bug Something isn't working
#53 opened May 11, 2021 by code423n4
2
LockIds not according to spec 0 (Non-critical) Confirmed documentation Improvements or additions to documentation
#52 opened May 11, 2021 by code423n4
1
Manager can grief with fees 2 (Med Risk) bug Something isn't working
#51 opened May 11, 2021 by code423n4
ProTip! no:milestone will show everything without a milestone.