You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The NFTXVaultUpgradeable.flashLoan is not correctly implemented according to EIP-3156 (but it tries to implement it as it inherits from IERC3156FlashLenderUpgradeable).
It misses the return and currently always returns false.
Impact
Always returning false indicates that the flash loan was unsuccessful when in reality it could have been successful.
This breaks any contract trying to integrate with it.
Recommended Mitigation Steps
Add the return statement: return super.flashLoan(...)
The text was updated successfully, but these errors were encountered:
Handle
@cmichelio
Vulnerability details
Vulnerability Details
The
NFTXVaultUpgradeable.flashLoan
is not correctly implemented according to EIP-3156 (but it tries to implement it as it inherits fromIERC3156FlashLenderUpgradeable
).It misses the return and currently always returns
false
.Impact
Always returning
false
indicates that the flash loan was unsuccessful when in reality it could have been successful.This breaks any contract trying to integrate with it.
Recommended Mitigation Steps
Add the return statement:
return super.flashLoan(...)
The text was updated successfully, but these errors were encountered: