Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of zero address check #147

Closed
code423n4 opened this issue Jun 16, 2021 · 2 comments
Closed

Lack of zero address check #147

code423n4 opened this issue Jun 16, 2021 · 2 comments
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

a_delamo

Vulnerability details

Impact

Some methods are missing validators to verify that address != 0.
A human error can produce that an invalid address is introduced and this check would help a bit to reduce issues.

    // RCOrderbook.sol
    constructor(address _factoryAddress, address _treasuryAddress) {
        factoryAddress = _factoryAddress;
        treasuryAddress = _treasuryAddress;
        treasury = IRCTreasury(treasuryAddress);
        uberOwner = msgSender();
    }

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

Tools Used

Recommended Mitigation Steps

@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Jun 16, 2021
code423n4 added a commit that referenced this issue Jun 16, 2021
@Splidge Splidge added the duplicate This issue or pull request already exists label Jun 17, 2021
@Splidge
Copy link
Collaborator

Splidge commented Jun 17, 2021

Duplicate of #56

@Splidge Splidge marked this as a duplicate of #56 Jun 17, 2021
@Splidge Splidge closed this as completed Jun 17, 2021
@dmvt
Copy link
Collaborator

dmvt commented Jul 11, 2021

duplicate of #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants