Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-entrancy mitigation #70

Open
code423n4 opened this issue Jul 28, 2021 · 0 comments
Open

Re-entrancy mitigation #70

code423n4 opened this issue Jul 28, 2021 · 0 comments
Labels
1 (Low Risk) bug Something isn't working sponsor acknowledged Sponsor acknowledged, but not resolving

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

I see no re-entrancy mitigations. Contracts interact with various outside sources (tokens, aave pools, other possible strategies that may be added in the future, etc). so, for instance, now you have to be careful and do not allow tokens that have a receiver callback (e.g. erc777) or untrustable sources of yield (strategies).

Recommended Mitigation Steps

Consider using ReentrancyGuard on main action functions: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/security/ReentrancyGuard.sol

@code423n4 code423n4 added 1 (Low Risk) bug Something isn't working labels Jul 28, 2021
code423n4 added a commit that referenced this issue Jul 28, 2021
@Evert0x Evert0x added the sponsor acknowledged Sponsor acknowledged, but not resolving label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 (Low Risk) bug Something isn't working sponsor acknowledged Sponsor acknowledged, but not resolving
Projects
None yet
Development

No branches or pull requests

2 participants