Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signatures are accepted for zero address #21

Closed
code423n4 opened this issue Sep 8, 2021 · 2 comments
Closed

signatures are accepted for zero address #21

code423n4 opened this issue Sep 8, 2021 · 2 comments
Labels

Comments

@code423n4
Copy link
Contributor

Handle

0xito

Vulnerability details

Impact

if verifysig is called with the zero address as the _signer any signature will be valid.
this is because ecrecover does not revert on wrong signatures but returns the zero address instead.

Proof of Concept

Tools Used

Recommended Mitigation Steps

revert if the return value of ecrecover is the zero address.
use openzeppelin's ecdsa.sol for further checks on signature verifications.

@jkilpatr
Copy link
Collaborator

duplicate of #43,#61,#28

@albertchon
Copy link
Collaborator

Duplicate of #61

@albertchon albertchon marked this as a duplicate of #61 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants