Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend adding a nonReentrant modifier to external functions #27

Open
code423n4 opened this issue Sep 5, 2021 · 2 comments
Open

Recommend adding a nonReentrant modifier to external functions #27

code423n4 opened this issue Sep 5, 2021 · 2 comments

Comments

@code423n4
Copy link
Contributor

Handle

tensors

Vulnerability details

Impact

The external functions given to the user have no checks for reentrancy.

An ounce of prevention is worth a pound of cure: when possible (i.e. most external functions)
could use a nonReentrant modifier.

I haven't been able to find any reentrancies in my search, but for complicated code like this it is recommended to
add checks anyway. It reduces the attack surface by an enormous amount.

@jeffywu
Copy link
Collaborator

jeffywu commented Sep 11, 2021

A best practice recommendation should be 0 Non Critical in my opinion. There is no explicit attack vector mentioned here.

@ghoul-sol
Copy link
Collaborator

This is a best practice recommendation, so non-critical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants